Re: [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter

From: Jason Gunthorpe
Date: Mon Jan 04 2016 - 13:28:02 EST


On Sun, Jan 03, 2016 at 07:26:50PM +0200, Jarkko Sakkinen wrote:
> > @@ -695,8 +685,8 @@ static int tpm_tis_init(struct device *dev, struct tpm_info *tpm_info,
> > #endif
> >
> > chip->vendor.iobase = devm_ioremap_resource(dev, &tpm_info->res);
> > - if (!chip->vendor.iobase)
> > - return -EIO;
> > + if (IS_ERR(chip->vendor.iobase))
> > + return PTR_ERR(chip->vendor.iobase);
>
> Isn't this a regression in the descendig patch in this series?

Oh yes, good catch.

The fix from Martin got rebased onto the wrong patch by accident.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/