Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support

[Dinh Nguyen]

On 01/04/2016 01:46 PM, Borislav Petkov wrote:
> On Mon, Jan 04, 2016 at 11:17:29AM -0600, Dinh Nguyen wrote:
>> We tried to jam the L2 and OCRAM EDAC functionality in the same
>> altr_edac.c file. It looks like it might be clean if we split out the L2
>> and OCRAM functions into their appropriate files(altr_edac_l2.c and
>> altr_edac_ocram.c). Do you agree?
> 
> "Clean" in what sense? To me clean is when there's a single compilation
> unit altera_edac.c which contains all Altera-specific code.
> 

altr_edac.c originally added support for SDRAM. Now we're adding support
for L2 and OCRAM into the same file by using #ifdef
CONFIG_EDAC_ALTERA_OCRAM and CONFIG_EDAC_ALTERA_L2C. So "clean" was to
move the l2 and ocram implementation into separate files.

Dinh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/