Re: [PATCH] drivers/bus: make uniphier-system-bus.c explicitly non-modular

[Masahiro Yamada]

2016-01-05 11:26 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
> Hi Paul,
>
>
> 2016-01-05 8:24 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
>> Hi Olof,
>>
>> Sorry my misunderstanding.
>>
>>
>> 2016-01-05 8:15 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
>>> Hi Paul, Olof,
>>>
>>> 2016-01-05 4:22 GMT+09:00 Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>:
>>>> The Kconfig currently controlling compilation of this code is:
>>>>
>>>> drivers/bus/Kconfig:config UNIPHIER_SYSTEM_BUS
>>>> drivers/bus/Kconfig:    bool "UniPhier System Bus driver"
>>>>
>>>> ...meaning that it currently is not being built as a module by anyone.
>>>>
>>>> Lets remove the modular code that is essentially orphaned, so that
>>>> when reading the driver there is no doubt it is builtin-only.
>>>>
>>>> Since module_platform_driver() uses the same init level priority as
>>>> builtin_platform_driver() the init ordering remains unchanged with
>>>> this commit.
>>>>
>>>> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>>>>
>>>> We also delete the MODULE_LICENSE tag etc. since all that information
>>>> is already contained at the top of the file in the comments.
>>>>
>>>> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>>> Cc: Rob Herring <robh@xxxxxxxxxx>
>>>> Cc: Arnd Bergmann <arnd@xxxxxxxx>
>>>> Cc: Olof Johansson <olof@xxxxxxxxx>
>>>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
>
>
>
> I assume commit 326ea45aa827 ("bus: uniphier: allow only built-in driver")
> is a temporary fix.
>
> I'd like to revive the tristate for this driver
> by hook or by crook.
>
>
> I've sent the following to fix the build error.
> http://www.thefreedictionary.com/

Sorry, I mean this one:
https://patchwork.kernel.org/patch/7952361/



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/