Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search

From: Dave Young
Date: Tue Jan 05 2016 - 00:20:32 EST


On 01/04/16 at 01:26pm, Borislav Petkov wrote:
> On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote:
> > Replied to Toshi old kernel will export the "GART" region for amd cards.
> > So for old kernel and new kexec-tools we will have problem.
> >
> > I think add the GART desc for compitibility purpose is doable, no?
>
> Just read your other mails too. If I see it correctly, there's only one
> place which has "GART":
>
> $ git grep -e \"GART\"
> arch/x86/kernel/crash.c:235: walk_iomem_res("GART", IORESOURCE_MEM, 0, -1,
>
> So crash.c only excludes this region but the kernel doesn't create it.
> Right?

Right.

>
> So we can kill that walk_iomem_res(), as you say. Which would be even
> nicer...

Yes, I think it is ok to kill walk_iomem_res()

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/