Re: [RFC PATCH v2] perf test: Improve bp_signal

From: Jiri Olsa
Date: Tue Jan 05 2016 - 05:07:21 EST


On Tue, Jan 05, 2016 at 09:57:55AM +0000, Wang Nan wrote:
> Will Deacon [1] has some question on patch [2]. This patch improves
> test__bp_signal so we can test:
>
> 1. A watchpoint and a breakpoint that fire on the same instruction
> 2. Nested signals
>
> Test result:
>
> On x86_64 and ARM64 (result are similar with patch [2] on ARM64):
>
> # ./perf test -v signal
> 17: Test breakpoint overflow signal handler :
> --- start ---
> test child forked, pid 10213
> count1 1, count2 3, count3 2, overflow 3, overflows_2 3
> test child finished with 0
> ---- end ----
> Test breakpoint overflow signal handler: Ok
>
> So at least 2 cases Will doubted are handled correctly.
>
> [1] http://lkml.kernel.org/g/20160104165535.GI1616@xxxxxxx
> [2] http://lkml.kernel.org/g/1450921362-198371-1-git-send-email-wangnan0@xxxxxxxxxx
>
> Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> ---
>
> v1 -> v2: Improve readability, fix typo. Thanks to Jiri Olsa.
>
> To Jiri: I guess you will be okay to provide your SOB for your code at [3],
> so I add it in this v2 patch.

sure, patch looks good to me

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/