Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support

[Thor Thayer]

On 01/05/2016 04:58 AM, Borislav Petkov wrote:
> On Mon, Jan 04, 2016 at 05:42:40PM -0600, Thor Thayer wrote:
> > and then the defines are also used to conditionally include the L2 or OCRAM
> > ECC functions because everything is in one file.
>
> So?
>
> You don't have to do those funny games in the Makefile. Instead, you
> have your main CONFIG_EDAC_ALTERA_MC option and all the other CONFIG_*
> options depend on it. The ifdeffery in altera_edac.c then takes care of
> what needs to be enabled or not.
>
> However(!), your driver is not huge or something. So I still don't
> understand why you need that split and those additional config options
> and why not keep it all together in one file. What is the compelling use
> case for that split and additional complexity?
>
> > However, the highbank and octeon edacs are split into separate files for L2
> > which Dinh pointed may be cleaner for individual control.
>
> I should've nacked that split at the time.
OK, Thanks for the clarification.

The CONFIG_EDAC_ALTERA_MC is a little confusing because it refers to the 
Memory Controller (SDRAM) and uses that in the menu string(Altera SDRAM 
Memory Controller EDAC).

Would it be confusing to rename this CONFIG_EDAC_ALTERA, update the 
SDRAM code to check the ECC Enable bit instead of this config option and 
update the string in the menu?

I'll keep this as one file and implement your suggested changes and 
resubmit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/