Re: [PATCH 22/32] x86, pkeys: dump PTE pkey in /proc/pid/smaps

[Dave Hansen]

On 01/05/2016 05:32 AM, Vlastimil Babka wrote:
> On 12/14/2015 08:06 PM, Dave Hansen wrote:
>> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> 
> $SUBJ is a bit confusing in that it's dumping stuff from VMA, not PTE's?

Yeah, absolutely.  That's a relic from when I thought I'd need to be
walking the page tables to figure this out.  I'll update it.

> It could be also useful to extend dump_vma() appropriately. Currently
> there are no string translations for the new "flags" (but one can figure
> it out from the raw value). But maybe we should print pkey separately in
> dump_vma() as you do here. I have a series in flight [1] that touches
> dump_vma() and the flags printing in general, so to avoid conflicts,
> handling pkeys there could wait. But mentioning it now for less chance
> of being forgotten...
> 
> [1] https://lkml.org/lkml/2015/12/18/178 - a previous version is in
> mmotm and this should replace it after 4.5-rc1

Ahhh, very nice.  I'll go back and add support for it once your patch lands.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/