Re: [PATCH v4 1/5] mtd: nand: return consistent error codes in ecc.correct() implementations

From: Brian Norris
Date: Wed Jan 06 2016 - 21:48:22 EST


On Wed, Dec 30, 2015 at 08:32:03PM +0100, Boris Brezillon wrote:
> The error code returned by the ecc.correct() are not consistent over the
> all implementations.
>
> Document the expected behavior in include/linux/mtd/nand.h and fix
> offending implementations.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/mtd/nand/atmel_nand.c | 2 +-
> drivers/mtd/nand/bf5xx_nand.c | 20 ++++++++++++++------
> drivers/mtd/nand/davinci_nand.c | 6 +++---
> drivers/mtd/nand/jz4740_nand.c | 4 ++--
> drivers/mtd/nand/mxc_nand.c | 4 ++--
> drivers/mtd/nand/nand_bch.c | 2 +-
> drivers/mtd/nand/nand_ecc.c | 2 +-
> drivers/mtd/nand/omap2.c | 6 +++---
> drivers/mtd/nand/r852.c | 4 ++--
> include/linux/mtd/nand.h | 8 +++++++-
> include/linux/mtd/nand_bch.h | 2 +-
> 11 files changed, 37 insertions(+), 23 deletions(-)

Pushed patch 1, with added commentary about the bf5xx_nand bugfix.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/