RE: [PATCH V2 0/3] Change notes of V2

[Yu, Xiangliang]

> From: Xiangliang Yu <Xiangliang.Yu@xxxxxxx>:
> > Main changes in V2:
> > 1. Fixed compiler warning;
> > 2. Add marcro argument of ndev in NTB_READ_REG/NTB_WRITE_REG; 3.
> Add
> > notes for flush and wakeup interfaces;
> >
> > Xiangliang Yu (3):
> >   NTB: Add AMD PCI-Express NTB driver
> >   NTB: Add AMD NTB support in Kconfig and Makefile
> >   NTB: Add flush_req and wakeup interface
> 
> Could you re-spin these patches as:
> 
> Patch 1:
> 	Only the parts of the driver that fit the current NTB APIs.
> 
> Patch 2:
> 	The new flush_req API, and the related code in the AMD driver.
> 
> Patch 3:
> 	The new wakeup API, and related code in the AMD driver.
> 
Ok.

> In particular, I think we need feedback on #3 from PCI and power
> management maintainers.
I don't get your concern.
I think we can add device attribute file to let application to trigger wakeup function, then NTB hardware will do the rest. NTB driver just need to implement suspend/resume interface of PCI PM.

Add one more thing, do you think NTB should support runtime power management?

> 
> When making #1, please make sure that the patch stands on its own, without
> any of the code related to #2 or #3 in #1.  Do put the makefile and kconfig
> changes in #1.
Ok.