Re: [PATCH 00/19] irqchip: atmel-aic: make unified AIC driver

[Milo Kim]

Hi Boris,

> > If AIC and AIC5 must be separate, then I'll try to rework
> > irq-atmel-common part.
>
> What would you like to rework? Could you describe in more details
> what's bothering you in this code?

I was about to modify irq-atmel-aic-common as below.

  * AIC5 handles for-loop twice during initialization.
  1) after IRQ generic chip is allocated successfully.
  2) map AIC5 IRQ chip operation after aic_common_of_init() returns.
  To reduce for-loop count, move each IRQ chip initialization code into 
common part.

  * AIC and AIC5 have same interrupt handling procedure, so each IRQ 
handler can be moved to common part.

BTW, I've sent another patch-set about fixing few things. Could you 
check them?

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/