Re: [PATCH 06/13] perf record: Store data mmaps for dwarf unwind

[Namhyung Kim]

On Thu, Jan 07, 2016 at 10:14:03AM +0100, Jiri Olsa wrote:
> Currently we don't synthesize data mmap by default. It depends
> on -d option, that enables data address sampling.
> 
> But we've seen cases (softice) where DWARF unwinder went through
> non executable mmaps, which we need to lookup in MAP__VARIABLE tree.
> 
> Making data mmaps to be synthesized for dwarf unwind as well.
> 
> Reported-by: Noel Grandin <noelgrandin@xxxxxxxxx>
> Link: http://lkml.kernel.org/n/tip-lh02yir6qfycn8zr892rmlgg@xxxxxxxxxxxxxx
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
>  tools/perf/builtin-record.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 9c5cdc2c4471..920b93edb497 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -804,6 +804,7 @@ int record_parse_callchain_opt(const struct option *opt,
>  	int ret;
>  	struct record_opts *record = (struct record_opts *)opt->value;
>  
> +	record->sample_address = true;

It seems unconditionally set, no?

Thanks,
Namhyung


>  	record->callgraph_set = true;
>  	callchain_param.enabled = !unset;
>  
> -- 
> 2.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/