Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters

From: Joerg Roedel
Date: Thu Jan 07 2016 - 07:34:18 EST


On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote:
> Currently, amd_iommu_pc_get_max_[banks|counters]() require devid,
> which should not be the case. Also, these don't properly support
> multi-IOMMU system.
>
> Current and future AMD systems with IOMMU that support perf counter
> would likely contain homogeneous IOMMUs where multiple IOMMUs are
> availalbe. So, this patch modifies these function to iterate all IOMMU
> to check the max banks and counters reported by the hardware.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> ---
> arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++----------
> drivers/iommu/amd_iommu_init.c | 20 ++++++++++++--------
> include/linux/perf/perf_event_amd_iommu.h | 7 ++-----
> 3 files changed, 21 insertions(+), 23 deletions(-)

Reviewed-by: Joerg Roedel <jroedel@xxxxxxx>

This looks like the fix for the CZ issue, right? If true, it is
probably v4.5 material.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/