Re: [PATCH] soc: qcom: Add support for SAW2 regulators

[Georgi Djakov]

On 12/18/2015 07:24 PM, Lina Iyer wrote:
> On Fri, Dec 18 2015 at 09:15 -0700, Georgi Djakov wrote:
>> The SAW2 (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper)
>> is part of the SPM subsystem. It is a hardware block found on some of the
>> Qualcomm chipsets, which regulates the power to the CPU cores. Add some
>> basic support for it, so that we can do dynamic voltage scaling.
>>
>> Signed-off-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>
>> ---
[..]
>> @@ -368,6 +510,11 @@ static int spm_dev_probe(struct platform_device *pdev)
>>
>>     per_cpu(cpu_spm_drv, cpu) = drv;
>>
>> +    ret = register_saw2_regulator(drv, pdev, cpu);
>>
> Not all SAWs are regulators. On 8084, only the L2 SAW is a regulator.
> You may want to parse the device node to see if it has a 'regulator'
> property and then initialize the regulator aspect of the SAW. L2 SAW
> nodes are not present in the upstream kernel. You can find a patch that
> adds cache SPM here in my WIP series at [1].

Yes, nice catch. Thank you!

BR,
Georgi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/