Re: [PATCH v3] acpi, apei: add Boot Error Record Table (BERT) support

From: G Gregory
Date: Thu Jan 07 2016 - 11:23:05 EST


On 7 January 2016 at 16:21, Fu Wei <fu.wei@xxxxxxxxxx> wrote:
> Hi Huang,
>
> On 7 January 2016 at 20:00, kbuild test robot <lkp@xxxxxxxxx> wrote:
>> Hi Huang,
>>
>> [auto build test WARNING on pm/linux-next]
>> [also build test WARNING on v4.4-rc8 next-20160106]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>>
>> url: https://github.com/0day-ci/linux/commits/fu-wei-linaro-org/acpi-apei-add-Boot-Error-Record-Table-BERT-support/20160107-193040
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
>> config: x86_64-lkp (attached as .config)
>> reproduce:
>> # save the attached .config to linux build tree
>> make ARCH=x86_64
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/acpi/apei/bert.c:31:14: warning: extra tokens at end of #undef directive
>> #undef pr_fmt(fmt)
>> ^
>>
>> vim +31 drivers/acpi/apei/bert.c
>>
>> 15 *
>> 16 * For more information about BERT, please refer to ACPI Specification
>> 17 * version 4.0, section 17.3.1
>> 18 *
>> 19 * This file is licensed under GPLv2.
>> 20 *
>> 21 */
>> 22
>> 23 #include <linux/kernel.h>
>> 24 #include <linux/module.h>
>> 25 #include <linux/init.h>
>> 26 #include <linux/acpi.h>
>> 27 #include <linux/io.h>
>> 28
>> 29 #include "apei-internal.h"
>> 30
>> > 31 #undef pr_fmt(fmt)
>
> Do you have any idea?
> I did not get warnings when I compiled this for arm64.
> But without it, I got "redefined" warning.
>
Shouldn't it be just

#undef pr_fmt

No arguments!

Graeme

>> 32 #define pr_fmt(fmt) "BERT: " fmt
>> 33
>> 34 static int bert_disable;
>> 35
>> 36 static void __init bert_print_all(struct acpi_bert_region *region,
>> 37 unsigned int region_len)
>> 38 {
>> 39 /*
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
>
>
> --
> Best regards,
>
> Fu Wei
> Software Engineer
> Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
> Ph: +86 21 61221326(direct)
> Ph: +86 186 2020 4684 (mobile)
> Room 1512, Regus One Corporate Avenue,Level 15,
> One Corporate Avenue,222 Hubin Road,Huangpu District,
> Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/