Re: [PATCH V2] coccinelle: flag HZ dependent constants being passed for jiffies

[Julia Lawall]

On Thu, 7 Jan 2016, Nicholas Mc Guire wrote:

> A large set of calls in the kernel takes jiffies as an argument - passing 
> in a constant makes the timeout HZ dependent which is wrong in all cases
> found by this spatch and probably is wrong for any call that expects 
> jiffies with the exception of passing in 1 (minimum delay). 
> 
> Checking for constants only yields many false positives so they are 
> filtered for digits only. A numeric value of 1 is though commonly in use 
> for "shortest possible delay" so those cases are treated as false 
> positives as well and not reported.

Could you try constant int C?

julia

> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> ---
> 
> V2: fixed up the documentation
> 
> This patch was tested with coccinelle version 1.0.4
> 
> patch is against linux-next (localversion-next is next-20160107)
> 
>  scripts/coccinelle/api/timeout_HZ_dependent.cocci | 125 ++++++++++++++++++++++
>  1 file changed, 125 insertions(+)
>  create mode 100644 scripts/coccinelle/api/timeout_HZ_dependent.cocci
> 
> diff --git a/scripts/coccinelle/api/timeout_HZ_dependent.cocci b/scripts/coccinelle/api/timeout_HZ_dependent.cocci
> new file mode 100644
> index 0000000..9da5092
> --- /dev/null
> +++ b/scripts/coccinelle/api/timeout_HZ_dependent.cocci
> @@ -0,0 +1,125 @@
> +/// Check for hard-coded numeric timeout values which are thus HZ dependent
> +//# Only report findings if the value is digits and != 1 as hard-coded
> +//# 1 seems to be in use for short delays.
> +//#
> +//# For kernel API that expects jiffies to be passed in a hard-coded value
> +//# makes the effective timeout dependent on the compile-time HZ setting
> +//# which is wrong in most (all?) cases. Any timeout should be passed
> +//# through msecs_to_jiffies() or usecs_to_jiffies() to make the timeout
> +//# values HZ independent.
> +//#
> +//# No patch mode for this, as converting the value from C to
> +//# msecs_to_jiffies(C) could be changing the effective timeout by more
> +//# than a factor of 10 so this always needs manual inspection Most notably
> +//# code that pre-dates variable HZ (prior to 2.4 kernel series) had HZ=100
> +//# so a constant of 10 should be converted to 100ms for any old driver.
> +//#
> +//# In some cases C-constants are passed in that are not converted to
> +//# jiffies, to locate these cases run in MODE=strict in which case these
> +//# will also be reported except if HZ is passed. Note though many are
> +//# likely to be false positives !
> +//
> +// Confidence: Medium
> +// Copyright: (C) 2015 Nicholas Mc Guire <hofrat@xxxxxxxxx>, OSADL, GPL v2
> +// URL: http://coccinelle.lip6.fr
> +// Options: --no-includes --include-headers
> +
> +virtual org
> +virtual report
> +virtual strict
> +
> +@cc depends on !patch && (context || org || report || strict)@
> +constant C;
> +position p;
> +@@
> +
> +(
> +schedule_timeout@p(C)
> +|
> +schedule_timeout_interruptible@p(C)
> +|
> +schedule_timeout_killable@p(C)
> +|
> +schedule_timeout_uninterruptible@p(C)
> +|
> +mod_timer(...,C)
> +|
> +mod_timer_pinned(...,C)
> +|
> +mod_timer_pending(...,C)
> +|
> +apply_slack(...,C)
> +|
> +queue_delayed_work(...,C)
> +|
> +mod_delayed_work(...,C)
> +|
> +schedule_delayed_work_on(...,C)
> +|
> +schedule_delayed_work(...,C)
> +|
> +schedule_timeout(C)
> +|
> +schedule_timeout_interruptible(C)
> +|
> +schedule_timeout_killable(C)
> +|
> +schedule_timeout_uninterruptibl(C)
> +|
> +wait_event_timeout(...,C)
> +|
> +wait_event_interruptible_timeout(...,C)
> +|
> +wait_event_uninterruptible_timeout(...,C)
> +|
> +wait_event_interruptible_lock_irq_timeout(...,C)
> +|
> +wait_on_bit_timeout(...,C)
> +|
> +wait_for_completion_timeout(...,C)
> +|
> +wait_for_completion_io_timeout(...,C)
> +|
> +wait_for_completion_interruptible_timeout(...,C)
> +|
> +wait_for_completion_killable_timeout(...,C)
> +)
> +
> +@script:python depends on org@
> +p << cc.p;
> +timeout << cc.C;
> +@@
> +
> +# schedule_timeout(1) for a "short" delay is not really HZ dependent
> +# as it always would be converted to 1 by msecs_to_jiffies as well
> +# so count this as false positive
> +if str.isdigit(timeout):
> +   if (int(timeout) != 1):
> +      msg = "WARNING: timeout is HZ dependent"
> +      coccilib.org.print_safe_todo(p[0], msg)
> +
> +@script:python depends on report@
> +p << cc.p;
> +timeout << cc.C;
> +@@
> +
> +if str.isdigit(timeout):
> +   if (int(timeout) != 1):
> +      msg = "WARNING: timeout (%s) seems HZ dependent" % (timeout)
> +      coccilib.report.print_report(p[0], msg)
> +
> +@script:python depends on strict@
> +p << cc.p;
> +timeout << cc.C;
> +@@
> +
> +# "strict" mode prints the cases that use C-constants != HZ
> +# as well as the numeric constants != 1. This will deliver a false
> +# positives if the C-constant is already in jiffies !
> +if str.isdigit(timeout):
> +   if (int(timeout) != 1):
> +      msg = "WARNING: timeout %s is HZ dependent" % (timeout)
> +      coccilib.report.print_report(p[0], msg)
> +elif (timeout != "HZ"):
> +   msg = "INFO: timeout %s may be HZ dependent" % (timeout)
> +   coccilib.report.print_report(p[0], msg)
> -- 
> 2.1.4
> 
>