Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list

From: Mike Kravetz
Date: Thu Jan 07 2016 - 18:51:56 EST


On 01/07/2016 03:13 PM, Andrew Morton wrote:
> On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
>
>> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine.
>> The argument end is of type pgoff_t. It was being converted to a
>> vaddr offset and passed to unmap_hugepage_range. However, end
>> was also being used as an argument to the vma_interval_tree_foreach
>> controlling loop. In addition, the conversion of end to vaddr offset
>> was incorrect.
>
> Could we please have a description of the user-visible effects of the
> bug? It's always needed for -stable things. And for all bugfixes, really.
>
> (stable@xxxxxxxxxxxxxxx[4.3] isn't an email address btw - my client barfed)

Will do.

As I stare at the code to come up with user visible effects, I am not
convinced the fix is correct. An update will come after more study.

--
Mike Kravetz