Re: [PATCH 1/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl

From: Christoph Hellwig
Date: Fri Jan 08 2016 - 03:35:54 EST


On Fri, Jan 08, 2016 at 09:31:14AM +0100, Bart Van Assche wrote:
> Indeed. All error paths in all target drivers will have to be modified to
> avoid that an acl reference leak is triggered if transport_init_session()
> fails after core_tpg_check_initiator_node_acl() succeeded.

I'm still hoping for a nice helper that does transport_init_session +
core_tpg_check_initiator_node_acl + transport_register_session to
isolated all that. It might need a callout to the driver somewhere
to be flexible enough but still would be a huge win..