Re: [PATCH v4 2/3] common: DMA-mapping: add DMA_ATTR_NOHUGEPAGE attribute

From: Russell King - ARM Linux
Date: Fri Jan 08 2016 - 08:36:09 EST


On Thu, Jan 07, 2016 at 04:36:44PM -0800, Douglas Anderson wrote:
> This patch adds the DMA_ATTR_NOHUGEPAGE attribute to the DMA-mapping
> subsystem.

It would be nicer to keep things in the positive-logic sense if at all
possible: flags that indicate "we don't want something" tend to end up
with double or triple negatives somewhere which makes understanding
the code much harder. It's a shame we have MADV_NOHUGEPAGE...

That's not a strong view, but a preference.

--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.