Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express

[Alex Williamson]

On Fri, 2016-01-08 at 14:49 -0600, Bjorn Helgaas wrote:
> [+cc Alex]
> 
> On Mon, Jan 04, 2016 at 05:47:14PM +0100, Tim Sander wrote:
> > Hi
> > 
> > Please consider this patch for the next release. It won't recognize
> > my Plextor
> > M6e PCIE disk without it. Please cc as i am not on the list.
> > 
> > Signed-off-by: Tim Sander <tim@xxxxxxxxxxxxxxx>
> > 
> > PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD
> > [Marvell 88SS9183] (rev 14)
> 
> Alex?

Aside from the style issues you've already commented on, I'll give a
thumbs up to quirking this device. ÂThanks,

Alex

> Please use a subject line that matches the other similar commits:
> 
> Â 247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120
> Â c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint
> RocketRaid 642L
> Â cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell
> devices
> 
> > ---
> > Âdrivers/pci/quirks.cÂÂÂÂ| 4 ++++
> > Âinclude/linux/pci_ids.h | 3 +++
> > Â2 files changed, 7 insertions(+)
> > 
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index 7e32730..93ec5a02 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI,
> > 0x0642,
> > ÂDECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂPCI_DEVICE_ID_JMICRON_JMB388_ESD,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂquirk_dma_func1_alias);
> > +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
> 
> Thanks for the link.ÂÂThere are 126 comments on that bugzilla so far,
> so it'd be nice to have a more specific pointer.ÂÂI'm guessing 117
> might be the relevant one, so:
> 
> Â https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117
> 
> > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂPCI_DEVICE_ID_PLEXTOR_M6E,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂquirk_dma_func1_alias);
> > Â
> > Â/*
> > Â * Some devices DMA with the wrong devfn, not just the wrong
> > function.
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index d9ba49c..01d8041 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2501,6 +2501,9 @@
> > Â
> > Â#define PCI_VENDOR_ID_ASMEDIAÂÂÂÂÂÂÂÂÂÂ0x1b21
> > Â
> > +#define PCI_VENDOR_ID_LITE_ONÂÂÂÂÂÂÂÂÂÂ0x1c28
> > +#define PCI_DEVICE_ID_PLEXTOR_M6EÂÂÂÂÂÂ0x0122
> 
> Since these constants are only used in one place, don't add them to
> pci_ids.h (see comment at the top of this file).ÂÂJust use the hex
> constants directly in the quirk and include the vendor/device names
> in
> the comment.
> 
> > Â#define PCI_VENDOR_ID_CIRCUITCOÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ0x1cc8
> > Â#define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
> > Â