Re: [RFC][PATCH] ppc: Implement save_stack_trace_regs()
From: Steven Rostedt
Date: Fri Jan 08 2016 - 17:51:03 EST
On Wed, 16 Dec 2015 12:24:19 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Wed, 09 Dec 2015 12:03:05 +1100
> Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>
> > > > Should I take this via powerpc or do you want it to go in via tracing?
> > >
> > > You can take it. And you can replace the PT_R1 if you want. I just
> > > noticed that it was defined, and I try to use macro names instead of
> > > hard coded numbers. I was actually looking for a "PT_SP" :-)
> >
> > OK thanks.
> >
> > Looks like we actually have:
> >
> > #define kernel_stack_pointer(regs) ((regs)->gpr[1])
> >
> > So that would be the most self documenting way to do it I guess, though I've
> > never actually seen that macro used anywhere before :)
>
> Hi,
>
> Are you going to take this, or do you want me to?
>
> -- Steve
Ping?
-- Steve