Re: [PATCH 1/2] crypto: af_alg - Add nokey compatibility path

From: Milan Broz
Date: Sat Jan 09 2016 - 05:15:46 EST


On 01/09/2016 06:41 AM, Herbert Xu wrote:
> On Fri, Jan 08, 2016 at 07:21:12PM +0100, Milan Broz wrote:
>>
>>> Yes algif_hash would need the same compatibility patch and I'm
>>> working on that.
>>
>> Ok, I fixed this already.
>
> Can you please test the two patches that I sent for algif_hash?

I have stack of 7 patches on top of Linus' 4.4.0-rc8 tree, just to be sure
that I am testing the right versions, I created a git branch with
imported series here:
http://git.kernel.org/cgit/linux/kernel/git/mbroz/linux.git/log/?h=crypto-api-compat

With these patches it works (except that cipher_null setkey issue).
I'll reply with tested-by to the patch thread.

>
>> So it is used in production but just for this specific case.
>
> OK I will add something similar to the algif_hash has_setkey
> logic for cipher_null.

Thanks!

Milan