Re: [PATCH v2 07/19] n_tty: Fix unsafe reference to "other" ldisc

From: Peter Hurley
Date: Sun Jan 10 2016 - 00:26:13 EST


On 01/09/2016 08:40 PM, Peter Hurley wrote:
> Although n_tty_check_unthrottle() has a valid ldisc reference (since
> the tty core gets the ldisc ref in tty_read() before calling the line
> discipline read() method), it does not have a valid ldisc reference to
> the "other" pty of a pty pair. Since getting an ldisc reference for
> tty->link essentially open-codes tty_wakeup(), just replace with the
> equivalent tty_wakeup().

Hi Greg,

Same here (forgot to re-mark this patch for stable).

Regards,
Peter Hurley