Re: [RESEND][PATCH 06/15] tty: audit: Ignore current association for audit push

From: Peter Hurley
Date: Sun Jan 10 2016 - 02:00:15 EST


On 01/09/2016 09:36 PM, kbuild test robot wrote:
> Hi Peter,

Thanks for the report. Just re-spun the v2 series with a fix for this.

Regards,
Peter Hurley

> [auto build test ERROR on tty/tty-testing]
> [also build test ERROR on next-20160108]
> [cannot apply to v4.4-rc8]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Peter-Hurley/Rework-tty-audit/20160110-130735
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: i386-randconfig-s0-201602 (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> Note: the linux-review/Peter-Hurley/Rework-tty-audit/20160110-130735 HEAD 3fdd6ed9cf68e96432c554fac7a14ef60e77efc3 builds fine.
> It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
> drivers/tty/n_tty.c: In function 'canon_copy_from_read_buf':
>>> drivers/tty/n_tty.c:2106:3: error: too few arguments to function 'tty_audit_push'
> tty_audit_push();
> ^
> In file included from drivers/tty/n_tty.c:40:0:
> include/linux/tty.h:626:20: note: declared here
> static inline void tty_audit_push(struct tty_struct *tty)
> ^
>
> vim +/tty_audit_push +2106 drivers/tty/n_tty.c
>
> 2100
> 2101 if (found) {
> 2102 if (!ldata->push)
> 2103 ldata->line_start = ldata->read_tail;
> 2104 else
> 2105 ldata->push = 0;
>> 2106 tty_audit_push();
> 2107 }
> 2108 return 0;
> 2109 }
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>