Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

[Stefan Wahren]

> MÃns RullgÃrd <mans@xxxxxxxxx> hat am 10. Januar 2016 um 14:42 geschrieben:
>
>
> Stefan Wahren <stefan.wahren@xxxxxxxx> writes:
>
> >> MÃns RullgÃrd <mans@xxxxxxxxx> hat am 10. Januar 2016 um 14:13 geschrieben:
> >>
> >>
> >> Stefan Wahren <stefan.wahren@xxxxxxxx> writes:
> >>
> >> > Hi Mans,
> >> >
> >> >> Mans Rullgard <mans@xxxxxxxxx> hat am 10. Januar 2016 um 13:40
> >> >> geschrieben:
> >> >>
> >> >>
> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> >> >
> >> > could you please change your patch to describe why you need to add
> >> > this pinmux?
> >>
> >> I'm working on a board that is wired that way. I can of course put this
> >> in the board-specific dts if that's preferable.
> >
> > So the board isn't submitted to mainline?
>
> Not yet anyway.
>
> > IMHO the change is okay, but the description doesn't explain why is it
> > needed.
> >
> > So a suitable description would be that it's needed for board xy.
>
> Would it be better to send this patch in a series along with the full
> board support?
>

Yes, it would be nice to have a dts file which reference the new pinmux.

> --
> MÃns RullgÃrd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel