Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed API change

From: Andrew Lunn
Date: Sun Jan 10 2016 - 10:45:51 EST


On Sun, Jan 10, 2016 at 07:08:04AM -0800, Guenter Roeck wrote:
> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the bfin_mac driver. This results in the following error message
>
> drivers/net/ethernet/adi/bfin_mac.c: In function 'mii_probe':
> drivers/net/ethernet/adi/bfin_mac.c:401:52: error:
> 'struct mii_bus' has no member named 'phy_map'
>
> Use phy_find_first() instead of open-coding it.
>
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Cc: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Acked-by: Andrew Lunn <andrew@xxxxxxx>

Hi Dave

Although Sadip Mukerjee's patch [PATCH 1/2] phy: fix blackfin build failure
is correct, this one is better. Please take this one in preference.
We do still however need Sadip's [2/2] bfin_mac: fix error path

Andrew