Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
From: Heiko Stuebner
Date: Sun Jan 10 2016 - 13:24:52 EST
Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng:
> Hi Heiko,
>
> > å 2016å1æ10æï18:29ïXing Zheng <zhengxing@xxxxxxxxxxxxxx> åéï
> >
> >
> > Hi Heiko,
> >
> >> å 2016å1æ10æï17:59ïHeiko Stuebner <heiko@xxxxxxxxx> åéï
> >>
> >> Hi Xing,
> >>
> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> >>> Because the RK3036 doesn't support EMAC, and only support the RMII
> >>> mode
> >>> in the EMAC IP, we refer to the TRM CRU and update the new external
> >>> clock name for EMAC.
> >>>
> >>> Signed-off-by: Xing Zheng <zhengxing@xxxxxxxxxxxxxx>
> >>
> >> as I said in the other mail, I already fixed the original patch myself
> >> :-) So I'm just going to drop this one.
> >>
> >>
> >> Heiko
> >>
> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c
> >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931>
> > I am sorry to misunderstand.
> >
> > OK, thank you for your help. :)
>
> Your patch is:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external GMAC clock - optional
>
> I think that these should be like this:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external EMAC clock - optional
I fixed that up now, thanks for catching this.
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371
Heiko