Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

[Uwe Kleine-König]

Hello,

On Sun, Jan 10, 2016 at 02:38:00PM +0100, Stefan Wahren wrote:
> > Måns Rullgård <mans@xxxxxxxxx> hat am 10. Januar 2016 um 14:13 geschrieben:
> > Stefan Wahren <stefan.wahren@xxxxxxxx> writes:
> >
> > > Hi Mans,
> > >
> > >> Mans Rullgard <mans@xxxxxxxxx> hat am 10. Januar 2016 um 13:40 geschrieben:
> > >>
> > >>
> > >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> > >
> > > could you please change your patch to describe why you need to add
> > > this pinmux?
> >
> > I'm working on a board that is wired that way. I can of course put this
> > in the board-specific dts if that's preferable.
> 
> So the board isn't submitted to mainline?
> 
> IMHO the change is okay, but the description doesn't explain why is it needed.
> 
> So a suitable description would be that it's needed for board xy.

The problem with pinmuxing on i.MX23/28 is that the order of pinmux
groups is to a certain degree important. So not everything is possible
in the machine specific dts. (I didn't have an eye on this issue, maybe
it's fixed in the meantime?)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |