Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519

From: xuejiancheng
Date: Sun Jan 10 2016 - 21:08:29 EST


Hello Russell,

On 2016/1/8 23:10, Russell King - ARM Linux wrote:
> On Fri, Jan 08, 2016 at 10:16:40AM +0800, Jiancheng Xue wrote:
>> + uart0: serial@12100000 {
>> + compatible = "arm,pl011", "arm,primecell";
>> + reg = <0x12100000 0x1000>;
>> + interrupts = <0 4 4>;
>
> Should the last digit there be IRQ_TYPE_LEVEL_HIGH (and same for the
> other interrupts= after this?)
>
> Thanks.
>

I'll include <dt-bindings/interrupt-controller/arm-gic.h> and use
IRQ_TYPE_LEVEL_HIGH instead. The interrupts specifier will be wrote
like this "interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;".

Thank you.

Jiancheng