Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option

[Sudeep Holla]

On 08/01/16 23:12, Andrew Morton wrote:
> On Fri, 8 Jan 2016 17:02:39 +0000 Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>
> > > +
> > > +			/*
> > > +			 * if not mirrored_kernelcore and ZONE_MOVABLE exists,
> > > +			 * range from zone_movable_pfn[nid] to end of each node
> > > +			 * should be ZONE_MOVABLE not ZONE_NORMAL. skip it.
> > > +			 */
> > > +			if (!mirrored_kernelcore && zone_movable_pfn[nid])
> > > +				if (zone == ZONE_NORMAL &&
> > > +				    pfn >= zone_movable_pfn[nid])
> > > +					continue;
> > > +
> >
> > I tried this with today's -next, the above lines gave compilation error.
> > Moved them below into HAVE_MEMBLOCK_NODE_MAP and tested it on ARM64.
> > I don't see the previous backtraces. Let me know if that's correct or
> > you can post a version that compiles correctly and I can give a try.
>
> Thanks.   I'll include the below and shall add your tested-by:, OK?

Yes this is the exact change I tested. Also I retested your latest patch
set with today's -next. So,

Tested-by: Sudeep Holla <sudeep.holla@xxxxxxx>

--
Regards,
Sudeep