RE: EMCCTD kernel driver Patch for review

[Seymour, Shane M]

> [MS>] I did run checkpatch.pl. And yes, there are many warnings as well. About VERSION_CODE
> warning, we actually have to run driver for multiple kernel versions, so does this mean that I
> submit the patch only for current or latest kernel version, and maintain a local copy of driver for
> all other versions ?

I'll give an example from PMC. Look at the upstream hpsa driver and compare that to the driver here (which is the downstream HPE version for SLES/RHEL):

http://sourceforge.net/projects/cciss/files/hpsa-3.0-tarballs/

They are somewhat different and the upstream version does not have any of the #ifdefs etc required to support downstream. Others may chime in but I'd expect that the upstream driver should be aimed at upstream (only) and downstream distro oriented drivers should be maintained out of band. Getting your driver into the kernel has a long term pay off in that it will eventually appear in a downstream distro once they pick up a kernel version that contains it and then they will take fixes for their distros from upstream. I'd expect you'll have a uphill battle getting your driver in if while it contains things like LINUX_VERSION_CODE and contains any other unjustified errors/warnings from checkpatch.pl.

Thanks
Shane