Re: [PATCH v3 39/41] xen/events: use virt_xxx barriers

From: David Vrabel
Date: Mon Jan 11 2016 - 06:12:23 EST


On 10/01/16 14:21, Michael S. Tsirkin wrote:
> drivers/xen/events/events_fifo.c uses rmb() to communicate with the
> other side.
>
> For guests compiled with CONFIG_SMP, smp_rmb would be sufficient, so
> rmb() here is only needed if a non-SMP guest runs on an SMP host.
>
> Switch to the virt_rmb barrier which serves this exact purpose.
>
> Pull in asm/barrier.h here to make sure the file is self-contained.
>
> Suggested-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Acked-by: David Vrabel <david.vrabel@xxxxxxxxxx>

David