Re: [PATCH v4 10/13] tty: serial: 8250: Suitably replace printk

[Andy Shevchenko]

On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> From: Phillip Raffeck <phillip.raffeck@xxxxxx>
> 
> This patch replaces printk by the corresponding variant of dev_* in
> order
> to fix checkpatch warnings. If no suitable device pointer is present,
> the
> corresponding pr_* variant is used.
> 

> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
> 

> @@ -141,13 +141,13 @@ int __init hp300_setup_serial_console(void)
> Â		if (DIO_ID(pa + DIO_VIRADDRBASE) & 0x80)
> Â			add_preferred_console("ttyS", port.line,
> "9600n8");
> Â#else
> -		printk(KERN_WARNING "Serial console is DCA but
> support is disabled (CONFIG_HPDCA)!\n");
> +		pr_warn("Serial console is DCA but support is
> disabled (CONFIG_HPDCA)!\n");
> Â		return 0;
> Â#endif
> Â	}
> Â
> Â	if (early_serial_setup(&port) < 0)
> -		printk(KERN_WARNING "hp300_setup_serial_console():
> early_serial_setup() failed.\n");
> +		pr_warn("hp300_setup_serial_console():
> early_serial_setup() failed.\n");

%s:â, __func__ ?

> Â	return 0;
> Â}
> Â#endif /* CONFIG_SERIAL_8250_CONSOLE */
> @@ -179,8 +179,9 @@ static int hpdca_init_one(struct dio_dev *d,
> Â	line = serial8250_register_8250_port(&uart);
> Â
> Â	if (line < 0) {
> -		printk(KERN_NOTICE "8250_hp300: register_serial()
> DCA scode %d"
> -		ÂÂÂÂÂÂÂ" irq %d failed\n", d->scode, uart.port.irq);
> +		dev_notice(&d->dev,
> +			ÂÂ"8250_hp300: register_serial() DCA scode
> %d irq %d failed\n",
> +			ÂÂd->scode, uart.port.irq);
> Â		return -ENOMEM;
> Â	}
> Â
> @@ -260,8 +261,8 @@ static int __init hp300_8250_init(void)
> Â		line = serial8250_register_8250_port(&uart);
> Â
> Â		if (line < 0) {
> -			printk(KERN_NOTICE "8250_hp300:
> register_serial() APCI"
> -			ÂÂÂÂÂÂÂ" %d irq %d failed\n", i,
> uart.port.irq);
> +			pr_notice("8250_hp300: register_serial()
> APCI %d irq %d failed\n",
> +				ÂÂi, uart.port.irq);

Inconsistent with dev_notice() above. Choose one which is most suitable
here.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy