Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable

[Vlastimil Babka]

On 01/09/2016 12:29 AM, Kirill A. Shutemov wrote:
> On Fri, Jan 08, 2016 at 01:59:08PM +0600, Alexander Kuleshov wrote:
>> This patch removes unused struct zone *z variable which is
>> appeared in 86051ca5eaf5 (mm: fix usemap initialization)
> 
> I guess it's a fix for 1e8ce83cd17f (mm: meminit: move page initialization
> into a separate function).

Yeah but it's not a bug, so a tag like that would be just noise.

>> 
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx>
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

>> ---
>>  mm/page_alloc.c | 2 --
>>  1 file changed, 2 deletions(-)
>> 
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 9d666df..9bde098 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
>>  	pg_data_t *pgdat = NODE_DATA(nid);
>>  	unsigned long end_pfn = start_pfn + size;
>>  	unsigned long pfn;
>> -	struct zone *z;
>>  	unsigned long nr_initialised = 0;
>>  
>>  	if (highest_memmap_pfn < end_pfn - 1)
>>  		highest_memmap_pfn = end_pfn - 1;
>>  
>> -	z = &pgdat->node_zones[zone];
>>  	for (pfn = start_pfn; pfn < end_pfn; pfn++) {
>>  		/*
>>  		 * There can be holes in boot-time mem_map[]s
>> -- 
>> 2.6.2.485.g1bc8fea
>> 
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>