Re: [PATCH] perf tools: Add missing sources in perf's MANIFEST

[Arnaldo Carvalho de Melo]

Em Mon, Jan 11, 2016 at 05:46:10PM +0800, Wangnan (F) escreveu:
> On 2016/1/11 17:43, Jiri Olsa wrote:
> >On Fri, Jan 08, 2016 at 02:23:57PM +0000, Wang Nan wrote:
> >>These losted headers are found in arm64 cross building:
> >>failed to build perf using tarball generated using
> >>
> >>  $ make perf-targz-src-pkg
> >>
> >>Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
> >>Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> >>Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> >>Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> >>---
> >>  tools/perf/MANIFEST | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >>diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
> >>index ce3932e..c0053af 100644
> >>--- a/tools/perf/MANIFEST
> >>+++ b/tools/perf/MANIFEST
> >>@@ -1,6 +1,7 @@
> >>  tools/perf
> >>  tools/arch/alpha/include/asm/barrier.h
> >>  tools/arch/arm/include/asm/barrier.h
> >>+tools/arch/arm64/include/asm/barrier.h
> >>  tools/arch/ia64/include/asm/barrier.h
> >>  tools/arch/mips/include/asm/barrier.h
> >>  tools/arch/powerpc/include/asm/barrier.h
> >>@@ -30,6 +31,7 @@ tools/lib/util/find_next_bit.c
> >>  tools/include/asm/atomic.h
> >>  tools/include/asm/barrier.h
> >>  tools/include/asm/bug.h
> >>+tools/include/asm-generic/atomic-gcc.h
> >>  tools/include/asm-generic/barrier.h
> >>  tools/include/asm-generic/bitops/arch_hweight.h
> >>  tools/include/asm-generic/bitops/atomic.h
> >tarpkg test just failed for me due to missing bitmap sources
> >I needed to add.. seems related to:
> >   915b0882c310 tools lib: Move bitmap.[ch] from tools/perf/ to tools/{lib,include}/
 
> I also saw this:
 
> http://lkml.kernel.org/g/56931E12.8030506@xxxxxxxxxx
 
> tarpkg works for me when I posted this patchset at Friday, but
> fail after I return back today...

Right, my turn, we all make mistakes ;-\

Anyway, I'm looking at git commit hooks to try and get this checked
automatically for future renames or when new files gets added that are
not listed in the MANIFEST file...

Thank you guys for spotting this! :-)

- Arnaldo