Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well.

[David Miller]

From: Manjeet Pawar <manjeet.p@xxxxxxxxxxx>
Date: Mon, 11 Jan 2016 14:32:25 +0530

> This patch enable network driver support for ARM64
> 
> Signed-off-by: Akhilesh Kumar <akhilesh.k@xxxxxxxxxxx>
> Signed-off-by: Manjeet Pawar <manjeet.p@xxxxxxxxxxx>

There is no _WAY_ this is valid.

This driver casts skb->data pointers to "u32" integers
and then casts it back to a pointer and proceeds to
dereference that pointer.

I don't think you even looked at the build when trying to
compile this on a 64-bit machine.

That makes me have absolutely no confidence in the changes
you submit to me.