Re: [PATCH] Documentation/kernel-parameters: update KMG units

From: Jonathan Corbet
Date: Mon Jan 11 2016 - 20:31:32 EST


On Wed, 23 Dec 2015 18:38:16 -0600
Robert Elliott <elliott@xxxxxxx> wrote:

> Since commit e004f3c7780d ("lib/cmdline.c: add size unit t/p/e to
> memparse") expanded memparse() to support T, P, and E units in addition
> to K, M, and G, all the kernel parameters that use that function became
> capable of more than [KMG] mentioned in kernel-parameters.txt.
>
> Expand the introduction to the units and change all existing [KMG]
> descriptions to [KMGTPE]. cma only had [MG]; reservelow only had [K].
>
> Add [KMGTPE] for hugepagesz and memory_corruption_check_size, which also
> use memparse().
>
> Update two source code files with comments mentioning [KMG].

So I've ended up dropping this one from the docs tree for now. In the
end, I just didn't want my pull request to include an explanation for why
the docs tree has a conflict on mm/page_alloc.c.... The change is good,
though, and shouldn't be lost. I'd say that either (1) Andrew can pick
it up and merge it with the other stuff he has, or (2) we can push it
through after mm has cleared. Either way, a version based on -mm would
be a good thing to have.

Thanks,

jon