Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Lee Jones]

On Tue, 12 Jan 2016, Yang, Wenyou wrote:

> Hi Lee,
> 
> > -----Original Message-----
> > From: Lee Jones [mailto:lee.jones@xxxxxxxxxx]
> > Sent: 2016å1æ11æ 13:49
> > To: Yang, Wenyou <Wenyou.Yang@xxxxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Pawel Moll <pawel.moll@xxxxxxx>;
> > Mark Rutland <mark.rutland@xxxxxxx>; Ian Campbell
> > <ijc+devicetree@xxxxxxxxxxxxxx>; Kumar Gala <galak@xxxxxxxxxxxxxx>; Ferre,
> > Nicolas <Nicolas.FERRE@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> > 
> > On Fri, 08 Jan 2016, Wenyou Yang wrote:
> > 
> > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > > subdevices:
> > >  - Regulator
> > >  - Charger
> > 
> > Is this really an MFD?  What special handling does it require?
> 
> Yes, this is an MFD, two sub devices: regulators and charger.
> 
> > 
> > > This patch adds documentation for ACT8945A DT bindings.
> > >
> > > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx>
> > > ---
> > >
> > >  Documentation/devicetree/bindings/mfd/act8945a.txt |   16
> > ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > new file mode 100644
> > > index 0000000..406db16
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > @@ -0,0 +1,16 @@
> > > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > > +
> > > +Required properties:
> > > + - compatible: "active-semi,act8945a".
> > > + - reg: the I2C slave address for the ACT8945A chip
> > > +
> > > +The chip exposes two subdevices:
> > > + - a regulators: see ../regulator/act8945a-regulator.txt
> > > + - a charger: see ../power/act8945a-charger.txt
> > > +
> > > +Example:
> > > +	mfd: act8945a@5b {
> > 
> > "mfd" is too generic to be a label.
> > 
> > Why do you need a label in any case?
> 
> Remove the mfd, use act8945a@5b.

Use pmic@5b

> > > +		compatible = "active-semi,act8945a";
> > > +		reg = <0x5b>;
> > > +		status = "okay";
> > > +	};
> > 
> > This doesn't look much like an MFD to me.
> 
> I will add the child nodes for its sub devices, inclusive pmic and charger nodes.

Very well.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog