[PATCH v5 1/7] remoteproc: debugfs: Check of invalid 'count' value

From: Lee Jones
Date: Tue Jan 12 2016 - 07:49:38 EST


If 'count' value is invalid, return early with an error.

Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
---
drivers/remoteproc/remoteproc_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 9d30809..f63464c 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -156,8 +156,8 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
char buf[10];
int ret;

- if (count > sizeof(buf))
- return count;
+ if (count > sizeof(buf) || count <= 0)
+ return -EINVAL;

ret = copy_from_user(buf, user_buf, count);
if (ret)
--
1.9.1