Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node

From: Srinivas Kandagatla
Date: Tue Jan 12 2016 - 09:19:13 EST




On 12/01/16 14:00, Arnd Bergmann wrote:
On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
To be consistent with other nodes move sdhci node under the soc node,
rather than using lable references.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>


Maybe remove the label as well if you are no longer using it?
Label "sdhc_1" in this case is used in aliases node.


My understanding so far was qcom specific dt want to use hierarchical dt nodes in the board files, but this brings the question of should we delete all the unused labels.

IMO, some unused labels are harmless and would give more consistency to the reader, removing them might not add great value.

Andy/Stephen, any comments?


--srini

Arnd