Re: [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT.

From: Tomasz Nowicki
Date: Tue Jan 12 2016 - 11:15:29 EST


On 12.01.2016 14:50, Lorenzo Pieralisi wrote:
On Wed, Dec 16, 2015 at 04:16:21PM +0100, Tomasz Nowicki wrote:
In order to probe PCIe host controller when booting with DT,
ARM64 is using drivers which defer IRQ assignment to device
enable time. It means that boot time DT specific irq map initialization
is always overridden, so lets remove that code.

Signed-off-by: Tomasz Nowicki <tn@xxxxxxxxxxxx>
---
arch/arm64/kernel/pci.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
index 023b983..f7948f5 100644
--- a/arch/arm64/kernel/pci.c
+++ b/arch/arm64/kernel/pci.c
@@ -51,16 +51,6 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
return pci_enable_resources(dev, mask);
}

-/*
- * Try to assign the IRQ number from DT when adding a new device
- */
-int pcibios_add_device(struct pci_dev *dev)
-{
- dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
-
- return 0;
-}
-

Actually, this patch should be part of Matthew's series:


Agree.

Matthew can you please add this patch to your series?

Thanks,
Tomasz