Re: [patch] mdio_bus: NULL dereference on allocation error

From: David Miller
Date: Tue Jan 12 2016 - 14:31:28 EST


From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 12 Jan 2016 12:34:36 +0300

> If bus = kzalloc() fails then we end up dereferencing bus when we do
> "bus->irq[i] = PHY_POLL;". The code is a little simpler if we reverse
> the NULL check and return directly on failure.
>
> Fixes: e7f4dc3536a4 ('mdio: Move allocation of interrupts into core')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied.