Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04

[Joshua Clayton]

Hi Lucas,
Thanks for the review. 

On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@xxxxxxxxxx> wrote:

> > Âdrivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
> 
> Missing documentation for the DT binding.
>

Thanks, will add. 

...

> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
> 
> > Âstatic const struct display_timing hannstar_hsd070pww1_timing = {
> > Â	.pixelclock = { 64300000, 71100000, 82000000 },
> > Â	.hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> > Â		.compatible = "hannstar,hsd070pww1",
> > Â		.data = &hannstar_hsd070pww1,
> > Â	}, {
> > +		.compatible = "sharp,lq101k1ly04",
> > +		.data = &sharp_lq101k1ly04,
> > +	}, {
> 
> Wrong insertion place again.
OK. Will reorder alphabetically also. 

Joshua