Re: [PATCH v2 2/3] x86: drop a comment left over from X86_OOSTORE

[One Thousand Gnomes]

On Wed, 13 Jan 2016 00:10:19 +0200
"Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:

> The comment about wmb being non-nop is a left over from before commit
> 09df7c4c8097 ("x86: Remove CONFIG_X86_OOSTORE").
> 
> It makes no sense now: if you have an SMP system with out of order
> stores, making wmb not a nop will not help.

There were never any IDT Winchip systems with SMP support, and they were
the one system that could enable OOSTORE (and it was worth up to 30% on
some workloads). The fencing it had was just for DMA devices.

Alan