Re: [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation

[Boris Brezillon]

On Wed, 13 Jan 2016 16:19:52 +0900
Milo Kim <milo.kim@xxxxxx> wrote:

> AIC5 priority value is updated twice -
> in aic_common_set_priority() and when updating AT91_AIC5_SMR.
> Variable, 'smr' has updated priority value (intspec[2]) in the first step,
> so no need to update it again in the second step.
> 
> Signed-off-by: Milo Kim <milo.kim@xxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Cc: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>
> Cc: Nicholas Ferre <nicolas.ferre@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx

Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>

Thanks,

Boris

> ---
>  drivers/irqchip/irq-atmel-aic5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c
> index f36f426..4f0d068 100644
> --- a/drivers/irqchip/irq-atmel-aic5.c
> +++ b/drivers/irqchip/irq-atmel-aic5.c
> @@ -273,7 +273,7 @@ static int aic5_irq_domain_xlate(struct irq_domain *d,
>  	irq_reg_writel(bgc, *out_hwirq, AT91_AIC5_SSR);
>  	smr = irq_reg_readl(bgc, AT91_AIC5_SMR);
>  	aic_common_set_priority(intspec[2], &smr);
> -	irq_reg_writel(bgc, intspec[2] | smr, AT91_AIC5_SMR);
> +	irq_reg_writel(bgc, smr, AT91_AIC5_SMR);
>  	irq_gc_unlock(bgc);
>  
>  	return ret;



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com