Re: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4?

From: Pali RohÃr
Date: Wed Jan 13 2016 - 05:32:53 EST


On Wednesday 13 January 2016 11:26:13 Sebastian Reichel wrote:
> On Wed, Jan 13, 2016 at 09:44:24AM +0100, Pali RohÃr wrote:
> > On Tuesday 12 January 2016 22:53:52 Pavel Machek wrote:
> > > Hi!
> > >
> > > > >>If not, tell me, and I can do it, but it will involve a lot of swaring...
> > > > >
> > > > >I'll give it a look over.
> > > >
> > > > OK, I'm still looking for a test setup, but this was definitely a problem,
> > > > could you give this a try?:
> > >
> > > Well, search no more. I tested it and seems to work ok. There's one
> > > more blank line in the source, so I had to apply patch by hand.
> > >
> > > Tested-by: Pavel Machek <pavel@xxxxxx>
> > > Acked-by: Pavel Machek <pavel@xxxxxx>
> > > Reported-by: Pavel Machek <pavel@xxxxxx>
> > > Cc: stable@xxxxxxxxxxxxxxx
> > >
> > > ? :-).
> > >
> > > And... thanks!
> > > Pavel
> >
> > There are more pending fixes for bq27xxx... Maybe your is duplicate?
>
> No, it's not a duplicate.
>
> > http://thread.gmane.org/gmane.linux.power-management.general/70090
> > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=69714
> > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=2110580

Hm... It looks like Pavel's patch is subset of this 3rd patch as it fix
function bq27xxx_battery_read_soc()

> > Sebastian, please take them and ideally send to stable@ for backporting.
>
> There is no need to send them to stable@, if they are properly
> tagged with a 'Fixes: <sha1> ("title")' tag, so please always
> include it in your commit messages, if possible :)

I have not sent those patches, but OK. In that email thread you can find
sha1 commit id which broke it.

--
Pali RohÃr
pali.rohar@xxxxxxxxx