Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024

[Laxman Dewangan]

On Wednesday 13 January 2016 06:39 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jan 13, 2016 at 06:07:51PM +0530, Laxman Dewangan wrote:
> > On Wednesday 13 January 2016 06:01 PM, Mark Brown wrote:
> > > What is FPS_SRC and why is it set from init_data?  A driver should never
> > > be looking at init_data.
> > When FPS_SRC is set to NONE (this is needed from platform data) then based
> > on constraint like boot enable/always enable, it need to be on desired
> > state. Otherwise we may endup with disabling the rail when setting to NONE
> > and create issue.
> What is "it" and why can't we check what the current configuration is
> while setting FPS to NONE?
I will have platform specific data in callback of enable/disable only.
Which call back do I need to set this? enable/disable or post register?

> > I need to set the FPS src properly for each rails before callback happen
> > from regulator init so that enable/disable/is_enable can handle it properly.
> Why not just reorder the callback so it happens before the constraints
> are applied?
which callback I need to reorder for getting the context for configruation?