Re: [PATCH 9/9] clk: tegra210: Initialize PLL_D2 to a sane rate

From: Thierry Reding
Date: Wed Jan 13 2016 - 09:03:28 EST


On Fri, Jan 08, 2016 at 01:45:14PM -0500, Rhyland Klein wrote:
> Initialize PLL_D2 to a sane rate at the start of the day.
>
> Signed-off-by: Rhyland Klein <rklein@xxxxxxxxxx>
> ---
> drivers/clk/tegra/clk-tegra210.c | 1 +
> 1 file changed, 1 insertion(+)

There are a lot of assumptions in this commit message. I'm asking myself
why does it need to be initialized to any rate at all? Isn't it up to
the user driver to set the PLL to whatever it knows to be a sane rate?
Why is 594 MHz a sane rate?

A good commit message should answer those questions.

Thierry

Attachment: signature.asc
Description: PGP signature