Re: [PATCH v5 04/15] tty: serial: 8250: Fix multiline comment style

[Andy Shevchenko]

On Wed, 2016-01-13 at 17:39 +0100, Anton Wuerfel wrote:
> Checkpatch outputs some warnings about incorrect comment style,
> which is fixed by this patch.
> 


> --- a/drivers/tty/serial/8250/8250_ingenic.c
> +++ b/drivers/tty/serial/8250/8250_ingenic.c
> @@ -152,14 +152,18 @@ static void ingenic_uart_serial_out(struct
> uart_port *p, int offset, int value)
> Â		break;
> Â
> Â	case UART_IER:
> -		/* Enable receive timeout interrupt with the
> -		Â* receive line status interrupt */
> +		/*
> +		Â* Enable receive timeout interrupt with the
> +		Â* receive line status interrupt

I'm pretty sure that at least one word could fit previous line.

Can you re-check your patches with sane editor setting for line
breaking (like 76 characters)?

> +		Â*/
> Â		value |= (value & 0x4) << 2;
> Â		break;
> Â
> Â	case UART_MCR:
> -		/* If we have enabled modem status IRQs we should
> enable modem
> -		Â* mode. */
> +		/*
> +		Â* If we have enabled modem status IRQs we should
> enable modem
> +		Â* mode.

To check.

> +		Â*/
> 

> @@ -367,8 +367,10 @@ static const struct pnp_device_id
> pnp_dev_table[] = {
> Â	{	"PNPCXXX",		UNKNOWN_DEV	},
> Â	/* More unknown PnP modems */
> Â	{	"PNPDXXX",		UNKNOWN_DEV	},
> -	/* Winbond CIR port, should not be probed. We should keep
> track
> -	ÂÂÂof it to prevent the legacy serial driver from probing it
> */
> +	/*
> +	Â* Winbond CIR port, should not be probed. We should keep
> track
> +	Â* of it to prevent the legacy serial driver from probing it

I would suggest to add dot at the end of sentences. Here and in the
rest of the places.


> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -250,9 +250,11 @@ static const struct serial8250_config
> uart_config[] = {
> Â		.fcr		= UART_FCR_ENABLE_FIFO |
> UART_FCR_R_TRIG_10,
> Â		.flags		= UART_CAP_FIFO |
> UART_CAP_AFE,
> Â	},
> -/* tx_loadsz is set to 63-bytes instead of 64-bytes to implement
> -workaround of errata A-008006 which states that tx_loadsz shouldÂÂbe
> -configured less than Maximum supported fifo bytes */
> +	/*
> +	Â* tx_loadsz is set to 63-bytes instead of 64-bytes to
> implement
> +	Â* workaround of errata A-008006 which states that tx_loadsz
> should be
> +	Â* configured less than Maximum supported fifo bytes

Ditto.

> --- a/drivers/tty/serial/8250/serial_cs.c
> +++ b/drivers/tty/serial/8250/serial_cs.c
> @@ -441,16 +441,20 @@ static int simple_config(struct pcmcia_device
> *link)
> Â	struct serial_info *info = link->priv;
> Â	int i = -ENODEV, try;
> Â
> -	/* First pass: look for a config entry that looks normal.
> -	Â* Two tries: without IO aliases, then with aliases */
> +	/*
> +	Â* First pass: look for a config entry that looks normal.
> +	Â* Two tries: without IO aliases, then with aliases

Ditto.

> @@ -480,8 +484,10 @@ static int multi_config_check(struct
> pcmcia_device *p_dev, void *priv_data)
> Â	if (p_dev->resource[1]->end)
> Â		return -EINVAL;
> Â
> -	/* The quad port cards have bad CIS's, so just look for a
> -	ÂÂÂwindow larger than 8 ports and assume it will be right */
> +	/*
> +	Â* The quad port cards have bad CIS's, so just look for a
> +	Â* window larger than 8 ports and assume it will be right

Ditto.

> -	/* Another check for dual-serial cards: look for either
> serial or
> -	ÂÂÂmultifunction cards that ask for appropriate IO port
> ranges */
> +	/*
> +	Â* Another check for dual-serial cards: look for either
> serial or
> +	Â* multifunction cards that ask for appropriate IO port
> ranges

Ditto.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy