Re: [PATCH v5 5/7] s390: mm/gup: add gup trace points

[Shi, Yang]

Hi folks,

Any comment for this one? The tracing part review has been done.

Thanks,
Yang


On 12/9/2015 1:22 PM, Yang Shi wrote:
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: linux-s390@xxxxxxxxxxxxxxx
> Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxx>
> ---
>   arch/s390/mm/gup.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/s390/mm/gup.c b/arch/s390/mm/gup.c
> index 12bbf0e..a1d5db7 100644
> --- a/arch/s390/mm/gup.c
> +++ b/arch/s390/mm/gup.c
> @@ -12,6 +12,8 @@
>   #include <linux/rwsem.h>
>   #include <asm/pgtable.h>
>
> +#include <trace/events/gup.h>
> +
>   /*
>    * The performance critical leaf functions are made noinline otherwise gcc
>    * inlines everything into a single function which results in too much
> @@ -188,6 +190,9 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
>   	end = start + len;
>   	if ((end <= start) || (end > TASK_SIZE))
>   		return 0;
> +
> +	trace_gup_get_user_pages_fast(start, nr_pages);
> +
>   	/*
>   	 * local_irq_save() doesn't prevent pagetable teardown, but does
>   	 * prevent the pagetables from being freed on s390.