Re: [PATCH 3/4] x86,asm: Re-work smp_store_mb()

From: Linus Torvalds
Date: Wed Jan 13 2016 - 13:38:15 EST


On Wed, Jan 13, 2016 at 8:42 AM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
>
> Oh, I think this means we need a "cc" clobber.

It's probably a good idea to add one.

Historically, gcc doesn't need one on x86, and always considers flags
clobbered. We are probably missing the cc clobber in a *lot* of places
for this reason.

But even if not necessary, it's probably a good thing to add for
documentation, and in case gcc semantcs ever change.

Linus